Changeset acd264

Timestamp:

09/21/09 22:35:18 (3 years ago)

Author:

Erik Ekman <yarrick@…>

Branches:

master

Children:

365aab

Parents:

269499

git-author:

Erik Ekman <yarrick@…> (09/21/09 22:35:18)

git-committer:

Erik Ekman <erik@…> (02/04/12 20:34:04)

Message:

Make sure replies with errors get the name parsed

File:

• src/dns.c (modified) (3 diffs)

src/dns.c

@@ -303 +303 @@
         switch (qr) {
         case QR_ANSWER:
-                if(qdcount < 1 || ancount < 1) {
-                        /* We may get both CNAME and A, then ancount=2 */
+                if(qdcount < 1) {
+                        /* We need a question */
                         return -1;
                 }
@@ -311 +311 @@
                         q->id = id;
 
+                /* Read name even if no answer, to give better error message */
                 readname(packet, packetlen, &data, name, sizeof(name));
                 CHECKLEN(4);
@@ -321 +322 @@
                         q->name[0] = name[0];
                         q->name[1] = '\0';
+                } 
+                
+                if (ancount < 1) {
+                        /* We may get both CNAME and A, then ancount=2 */
+                        return -1;
                 }