Ticket #10 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Error in delayed ack

Reported by: yarrick Owned by: yarrick
Priority: major Milestone: 0.4.0 "Run Home"
Version: 0.4.0 "Run Home" Keywords:
Cc:

Description

In 0.3.4, ping response times were like this:

PING 172.29.0.1 (172.29.0.1) 56(84) bytes of data.
64 bytes from 172.29.0.1: icmp_seq=1 ttl=64 time=17.5 ms
64 bytes from 172.29.0.1: icmp_seq=2 ttl=64 time=16.6 ms
64 bytes from 172.29.0.1: icmp_seq=3 ttl=64 time=16.4 ms
64 bytes from 172.29.0.1: icmp_seq=4 ttl=64 time=16.9 ms
64 bytes from 172.29.0.1: icmp_seq=5 ttl=64 time=16.3 ms

In current svn (rev 412) the packets are more and more delayed:

PING 172.19.0.1 (172.19.0.1) 56(84) bytes of data.
64 bytes from 172.19.0.1: icmp_seq=1 ttl=64 time=23.2 ms
64 bytes from 172.19.0.1: icmp_seq=2 ttl=64 time=50.3 ms
64 bytes from 172.19.0.1: icmp_seq=3 ttl=64 time=69.4 ms
64 bytes from 172.19.0.1: icmp_seq=4 ttl=64 time=90.8 ms
64 bytes from 172.19.0.1: icmp_seq=5 ttl=64 time=109 ms
64 bytes from 172.19.0.1: icmp_seq=6 ttl=64 time=129 ms
64 bytes from 172.19.0.1: icmp_seq=7 ttl=64 time=149 ms
64 bytes from 172.19.0.1: icmp_seq=8 ttl=64 time=169 ms

Something broke during the refactoring. Check the server for delayed ack timeouts.

Change History

comment:1 Changed 5 years ago by yarrick

  • Owner set to yarrick
  • Status changed from new to assigned

Fixed bad endianness in q.id, now small pings (<110 work ok) [416]

comment:2 Changed 5 years ago by yarrick

20:57:48.232626 IP (tos 0x0, ttl  64, id 0, offset 0, flags [DF], proto: ICMP (1), length: 139) 172.19.0.2 > 172.19.0.1: ICMP echo request, id 13149, seq 4, length 119
        0x0000:  0000 fffe 0000 da24 0000 0000 0000 0800  .......$........
        0x0010:  4500 008b 0000 4000 4001 e248 ac13 0002  E.....@.@..H....
        0x0020:  ac13 0001 0800 1eef 335d 0004 3c8c c745  ........3]..<..E
        0x0030:  9a10 0000 0809 0a0b 0c0d 0e0f 1011 1213  ................
        0x0040:  1415 1617 1819 1a1b 1c1d 1e1f 2021 2223  .............!"#
        0x0050:  2425 2627 2829 2a2b 2c2d 2e2f 3031 3233  $%&'()*+,-./0123
        0x0060:  3435 3637 3839 3a3b 3c3d 3e3f 4041 4243  456789:;<=>?@ABC
        0x0070:  4445 4647 4849 4a4b 4c4d 4e4f 5051 5253  DEFGHIJKLMNOPQRS
        0x0080:  5455 5657 5859 5a5b 5c5d 5e5f 6061 6263  TUVWXYZ[\]^_`abc
        0x0090:  6465 6667 6869 6a6b 6c6d 6e56 4753 3938  defghijklmnVGS98
        0x00a0:  3f49 364c 5536 5857 4139 4445 4e52 5247  ?I6LU6XWA9DENRRG
        0x00b0:  555a 544f 4d46 5557 4b38 4c44 4e4e 5435  UZTOMFUWK8LDNNT5
        0x00c0:  2d59 4849 3754 574f                      -YHI7TWO
20:58:01.365607 IP (tos 0x0, ttl  64, id 0, offset 0, flags [DF], proto: ICMP (1), length: 140) 172.19.0.2 > 172.19.0.1: ICMP echo request, id 20829, seq 1, length 120 (wrong icmp cksum d975 (->d984)!)
        0x0000:  0000 fffe 0000 da24 0000 0000 0000 0800  .......$........
        0x0010:  4500 008c 0000 4000 4001 e247 ac13 0002  E.....@.@..G....
        0x0020:  ac13 0001 0800 d975 515d 0001 498c c745  .......uQ]..I..E
        0x0030:  b21d 0200 0809 0a0b 0c0d 0e0f 1011 1213  ................
        0x0040:  1415 1617 1819 1a1b 1c1d 1e1f 2021 2223  .............!"#
        0x0050:  2425 2627 2829 2a2b 2c2d 2e2f 3031 3233  $%&'()*+,-./0123
        0x0060:  3435 3637 3839 3a3b 3c3d 3e3f 4041 4243  456789:;<=>?@ABC
        0x0070:  4445 4647 4849 4a4b 4c4d 4e4f 5051 5253  DEFGHIJKLMNOPQRS
        0x0080:  5455 5657 5859 5a5b 5c5d 5e5f 6061 6263  TUVWXYZ[\]^_`abc
        0x0090:  6465 6667 6869 6a6b 6c6d 6e60 4753 3938  defghijklmn`GS98
        0x00a0:  3f49 364c 5536 5857 4139 4445 4e52 5247  ?I6LU6XWA9DENRRG
        0x00b0:  555a 544f 4d46 5557 4b38 4c44 4e4e 5435  UZTOMFUWK8LDNNT5
        0x00c0:  2d59 4849 3754 574f                      -YHI7TWO

This is two icmp pings. The first one is 119 bytes (111 bytes data) and working, the second one is 120 bytes (112 bytes data) and it has incorrect icmp checksum..

comment:3 Changed 5 years ago by yarrick

21:19:01.660688 IP (tos 0x0, ttl  64, id 0, offset 0, flags [DF], proto: ICMP (1), length: 140) 172.19.0.2 > 172.19.0.1: ICMP echo request, id 21861, seq 1, length 120 (wrong icmp cksum 611d (->6124)!)
        0x0000:  0000 fffe 0000 da24 0000 0000 0000 0800  .......$........
        0x0010:  4500 008c 0000 4000 4001 e247 ac13 0002  E.....@.@..G....
        0x0020:  ac13 0001 0800 611d 5565 0001 3591 c745  ......a.Ue..5..E
        0x0030:  3569 0700 0809 0a0b 0c0d 0e0f 1011 1213  5i..............
        0x0040:  1415 1617 1819 1a1b 1c1d 1e1f 2021 2223  .............!"#
        0x0050:  2425 2627 2829 2a2b 2c2d 2e2f 3031 3233  $%&'()*+,-./0123
        0x0060:  3435 3637 3839 3a3b 3c3d 3e3f 4041 4243  456789:;<=>?@ABC
        0x0070:  4445 4647 4849 4a4b 4c4d 4e4f 5051 5253  DEFGHIJKLMNOPQRS
        0x0080:  5455 5657 5859 5a5b 5c5d 5e5f 6061 6263  TUVWXYZ[\]^_`abc
        0x0090:  6465 6667 6869 6a6b 6c6d 6e68 544a 4e4e  defghijklmnhTJNN <-- should be defghijklmno
        0x00a0:  3f55 4f56 394d 3854 414e 4253 4759 5954  ?UOV9M8TANBSGYYT
        0x00b0:  4b4d 3658 5743 394c 464e 5652 5757 5a58  KM6XWC9LFNVRWWZX
        0x00c0:  4f37 4455 4f4a 3848 4336 4c54 352d 5950  O7DUOJ8HC6LT5-YP
        0x00d0:  4a37 5857 3548 392d 4744 5949 4251 4641  J7XW5H9-GDYIBQFA
        0x00e0:  2c37 4349 4e42 4f48 5952 4445 4b52 3945  ,7CINBOHYRDEKR9E
        0x00f0:  5938 4339 504a 4247 4555 5453 4a4a 5646  Y8C9PJBGEUTSJJVF
        0x0100:  372d 5347 4d5a 4c48 4d54 544f 4c01 6104  7-SGMZLHMTTOL.a.
        0x0110:  6b72 796f 0273 6500 000a 0001 c00c 000a  kryo.se.........
        0x0120:  0001 0000 0000 0000 0000 0000            ............

an icmp packet clearly containing some hostname instead of last expected character

comment:4 Changed 5 years ago by yarrick

  • Status changed from assigned to closed
  • Resolution set to fixed

Finally fixed this one [420]. encoding.c is really a mess, replace with base32.c and move other stuff to iodine(d).c some day

Note: See TracTickets for help on using tickets.